Add support for single record queries by primary key #590
Conversation
|
Hey @spitfire55 , thanks for this PR. We haven't forgotten this, just totally slammed right now. Will come back to it eventually. @olirice before we review this, do you an opinion on the approach here. Do we want to add a method to access object by pk as implemented in this PR? |
|
yes, i think there's been enough demand for it to justify the addition + it doesn't introduce any performance issues Like Raminder mentioned, we're pretty slammed right now so it may take some time to work through this and review so sorry in advance for that! From a very quick glance the things that jumped out are
appreciate your work on this, looking forward to getting it merged |
spitfire55
force-pushed
the
single_record_query_by_pk
branch
from
21cb2a1 to
59bc719
Compare
spitfire55
force-pushed
the
single_record_query_by_pk
branch
from
59bc719 to
42e65cb
Compare
spitfire55
force-pushed
the
single_record_query_by_pk
branch
from
42e65cb to
27e5503
Compare
spitfire55
force-pushed
the
single_record_query_by_pk
branch
2 times, most recently
from
e73b7aa to
5c033e1
Compare
- Fix TODO nodeId check, move out of transpile into builder - Create SupportedPrimaryKeyType enum for PK type matching
spitfire55
force-pushed
the
single_record_query_by_pk
branch
from
5c033e1 to
e434169
Compare
|
@spitfire55 I'll find some time today or tomorrow to review it. Sorry for the delay and thanks again for your patience. |
|
LGTM apart from missing docs. @olirice would you like to take a look? |
There was a problem hiding this comment.
@imor conceptually I'm on board
but there are several untested pathes. The biggest ones are:
- nodeByPk with a nested function ref
- nodeByPk with a connection ref
- introspection including __typename ref
- selecting an unknown field ref
If
- we can resolve the coverage issues ^ + not have this PR decrease coverage
- you've reviewed the code, are happy with it
- its been tested in GraphiQL manually to make there are no errors and looks as expected with a few sample tables
- docs
then we'll be good to go
|
@spitfire55 would you mind making changes suggested by @olirice. |
What kind of change does this PR introduce?
Users can now use [table_name]ByPk(key) queries to get a single record using the primary key
What is the current behavior?
No first-party support for single record queries by primary key.
See #554 .
What is the new behavior?
Adds a [table_name]ByPk(pk: pk_type) method to all tables that define a primary key